Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ga: colorful output #1807

Merged
merged 2 commits into from
Feb 14, 2023
Merged

ga: colorful output #1807

merged 2 commits into from
Feb 14, 2023

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Feb 14, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #1807 (b6d6957) into main (1969a65) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1807   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files          44       44           
  Lines        8102     8102           
  Branches     2218     2218           
=======================================
  Hits         6773     6773           
  Misses        849      849           
  Partials      480      480           
Impacted Files Coverage Δ
cwltool/main.py 74.73% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice! Confirmed output of jobs in this PR have colors, while the same jobs in previous PR's did not.

image

image

@mr-c
Copy link
Member Author

mr-c commented Feb 14, 2023

@kinow Thanks! I wish this was the default everywhere. We have so many repos!

@kinow
Copy link
Member

kinow commented Feb 14, 2023

@kinow Thanks! I wish this was the default everywhere. We have so many repos!

Hmmm, GH Actions at organization levels seem to focus more on permissions/security at the moment… however, what about required workflows, @mr-c? Wouldn't a required workflow run for every repository as a check? And in that case, creating an env in that required workflow... would it apply variables to every other workflow?

@mr-c
Copy link
Member Author

mr-c commented Feb 14, 2023

@kinow Thanks! I wish this was the default everywhere. We have so many repos!

Hmmm, GH Actions at organization levels seem to focus more on permissions/security at the moment… however, what about required workflows, @mr-c? Wouldn't a required workflow run for every repository as a check? And in that case, creating an env in that required workflow... would it apply variables to every other workflow?

Interesting, I didn't know about that feature. However we have a lot of variation (not to mention non-code repos, and multiple languages). It probably wouldn't be worth the effort just to have some environment variables set.

@mr-c mr-c merged commit c69221b into main Feb 14, 2023
@mr-c mr-c deleted the ga_pretty_colors branch February 14, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants