Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed race condition which happens when a job runs "too fast", #1890

Merged

Conversation

jmfernandez
Copy link
Contributor

@jmfernandez jmfernandez commented Aug 21, 2023

When a podman process finishes even before reaching the monitoring method, a deadlock happens, as no one is updating process.returncode and spawned process is in zombie state (so, no signal is sent).

This fix adds a process.poll() call, so it gives the chance to fill in process.returncode.

Fixes: #1883

When a podman process finishes even before reaching the monitoring
method, a deadlock happens, as no one is updating `process.returncode`
and spawned process is in zombie state (so, no signal is sent).

This fix adds a `process.poll()` call, so it gives the chance to fill in
`process.returncode`.
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1890 (71333c9) into main (5a645df) will decrease coverage by 3.48%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
- Coverage   83.91%   80.43%   -3.48%     
==========================================
  Files          46       46              
  Lines        8150     8152       +2     
  Branches     2169     2170       +1     
==========================================
- Hits         6839     6557     -282     
- Misses        842     1041     +199     
- Partials      469      554      +85     
Files Changed Coverage Δ
cwltool/job.py 81.99% <50.00%> (+0.07%) ⬆️

... and 13 files with indirect coverage changes

@mr-c mr-c merged commit 0baf100 into common-workflow-language:main Aug 21, 2023
43 of 45 checks passed
@mr-c
Copy link
Member

mr-c commented Aug 21, 2023

Thank you @jmfernandez !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlock with podman (at least 4.5.0) and simple workflow
2 participants