Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit calling cwltool.main with preparsed args only even with provenance #1964

Conversation

davidjsherman
Copy link
Contributor

Permit calling cwltool.main with preparsed args only, even when requesting provenance.

  • Parameter argsl, the unparsed arguments, is now optional in cwltool.setup_provenance. Since it has a default value it must be moved to the end of the parameter list.
  • Unit tests test_main_parsed_args and test_main_parsed_args_provenance verify that cwltool.main can be called with parsed arguments only, respectively with and without a request for provenance.

Closes #1963

@davidjsherman davidjsherman changed the title Main parsed args and provenance Permit calling cwltool.main with preparsed args only even with provenance Jan 6, 2024
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ff1fd0) 83.78% compared to head (08e5b9c) 83.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
+ Coverage   83.78%   83.86%   +0.08%     
==========================================
  Files          46       46              
  Lines        8221     8219       -2     
  Branches     2182     2181       -1     
==========================================
+ Hits         6888     6893       +5     
+ Misses        855      853       -2     
+ Partials      478      473       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-c mr-c merged commit a84911d into common-workflow-language:main Jan 8, 2024
45 checks passed
@davidjsherman davidjsherman deleted the main-parsed-args-and-provenance branch January 8, 2024 21:37
@davidjsherman
Copy link
Contributor Author

Thanks!

@cwl-bot
Copy link

cwl-bot commented Jan 13, 2024

This pull request has been mentioned on Common Workflow Language Discourse. There might be relevant details there:

https://cwl.discourse.group/t/cwltool-main-text-arguments-a-hard-requirement-for-provenance/862/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling cwltool.main() with preparsed args and provenance fails unless unparsed args are also provided
3 participants