Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prov data input output #1989

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Prov data input output #1989

wants to merge 23 commits into from

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Apr 3, 2024

No description provided.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 56.98925% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 69.76%. Comparing base (dd2e1ba) to head (c979e29).

Files Patch % Lines
cwltool/cwlprov/ro.py 42.00% 24 Missing and 5 partials ⚠️
cwltool/cwlprov/__init__.py 50.00% 6 Missing ⚠️
cwltool/cwlprov/provenance_profile.py 42.85% 4 Missing ⚠️
cwltool/cwlprov/writablebagfile.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1989       +/-   ##
===========================================
- Coverage   83.82%   69.76%   -14.06%     
===========================================
  Files          46       46               
  Lines        8245     8303       +58     
  Branches     2190     2105       -85     
===========================================
- Hits         6911     5793     -1118     
- Misses        856     1886     +1030     
- Partials      478      624      +146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjkoehorst
Copy link
Contributor

@mr-c I think I fixed the code make cleanup could you have a look at the other tests? Not sure if they fail due to this implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants