Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Location Header in CORS #189

Closed
coverbeck opened this issue Feb 6, 2018 · 1 comment · Fixed by #190
Closed

Expose Location Header in CORS #189

coverbeck opened this issue Feb 6, 2018 · 1 comment · Fixed by #190
Assignees
@coverbeck
Labels
bug

Comments

@coverbeck
Copy link
Contributor

Description

Cwlviewer should add Access-Control-Expose-Headers: Location.

When doing a POST to add a new workflow, if the response status is a 202, the Location header indicates the url to check the queue status. Because the above header is not in the response, the browser cannot see the location of the queue, and thus cannot check the queue status.

This relates to #186 and dockstore/dockstore#1058.
@coverbeck
Copy link
Contributor Author

I am working on a fix for this -- putting the comment here because I belatedly realized I don't have permissions to assign myself the ticket.

coverbeck added a commit to coverbeck/cwlviewer that referenced this issue Feb 7, 2018
@coverbeck
Expose Location header in CORS common-workflow-language#189
7eb5c17 
Also update README.md explaining how to get unit tests running
coverbeck added a commit to coverbeck/cwlviewer that referenced this issue Feb 7, 2018
@coverbeck
Expose Location header in CORS common-workflow-language#189
7061d4f 
Also update README.md explaining how to get unit tests running
coverbeck added a commit to coverbeck/cwlviewer that referenced this issue Feb 7, 2018
@coverbeck
Expose Location header in CORS common-workflow-language#189
6efcf7a 
Also update README.md explaining how to get unit tests running
coverbeck added a commit to coverbeck/cwlviewer that referenced this issue Feb 7, 2018
@coverbeck
Expose Location header in CORS common-workflow-language#189
90f3e4c 
Also update README.md explaining how to get unit tests running
@coverbeck coverbeck mentioned this issue Feb 7, 2018
Merged
7 tasks
@mr-c mr-c added the bug label Feb 9, 2018
@mr-c mr-c closed this as completed in #190 Feb 9, 2018
mr-c added a commit that referenced this issue Feb 9, 2018
@mr-c
Merge pull request #190 from coverbeck/location_header_for_cors
b1c3042 
Expose Location header in CORS #189
@coverbeck coverbeck mentioned this issue Mar 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coverbeck coverbeck

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose Location header in CORS #189 coverbeck/cwlviewer
2 participants
@coverbeck @mr-c