Upgrading to Spring Boot 3 #568
Conversation
| @@ -1,4 +1,4 @@ | |||
| version: '3.9' | |||
| version: '3.2' | |||
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| package org.commonwl.view.cwl; | |||
|
|
|||
| import javax.validation.ValidationException; | |||
| import jakarta.validation.ValidationException; | |||
There was a problem hiding this comment.
Note: Iacopo might have to test a deploy of this version, to make sure the server is using jakarta and not javax too.
|
|
||
| @TypeDefs({@TypeDef(name = "json", typeClass = JsonBinaryType.class)}) |
There was a problem hiding this comment.
Not needed with Hibernate 6.
| @@ -2,16 +2,17 @@ | |||
|
|
|||
| import com.fasterxml.jackson.annotation.JsonIgnoreProperties; | |||
| import com.fasterxml.jackson.annotation.JsonInclude; | |||
| import io.hypersistence.utils.hibernate.type.json.JsonBinaryType; | |||
There was a problem hiding this comment.
They renamed the package hibernate-entity-60, to this hypersistence.
| @@ -14,7 +14,7 @@ | |||
| * issues with serialization. | |||
| */ | |||
| public interface QueuedWorkflowRepository | |||
| extends JpaRepository<QueuedWorkflow, String>, QueuedWorkflowRepositoryCustom { | |||
| extends CrudRepository<QueuedWorkflow, String>, QueuedWorkflowRepositoryCustom { | |||
There was a problem hiding this comment.
JpaRepository now doesn't have the save method, so using this CrudRepository that contains the four ops.
| @@ -214,7 +214,7 @@ public ModelAndView getWorkflow( | |||
| * @param branch The branch of the repository | |||
| * @return The workflow view with the workflow as a model | |||
| */ | |||
| @GetMapping(value = "/workflows/**/*.git/{branch}/**") | |||
| @GetMapping(value = "/workflows/*/*.git/{branch}/**") | |||
There was a problem hiding this comment.
This needs to be well tested.
Now Spring Web doesn't allow any content after the /**. I found an issue or blog that suggested to test with /*/bla instead. Trying to get the tests and build to pass in order to verify it in the browser.
| @@ -9,7 +9,7 @@ | |||
| class="ch.qos.logback.core.ConsoleAppender"> | |||
| <layout class="ch.qos.logback.classic.PatternLayout"> | |||
| <Pattern> | |||
| %black(%d{ISO8601}) %highlight(%-5level) [%blue(%t)] %yellow(%C{1.}): %msg%n%throwable | |||
| %black(%d{ISO8601}) %highlight(%-5level) [%blue(%t)] %yellow(%C{1}): %msg%n%throwable | |||
There was a problem hiding this comment.
Was getting a NumberFormatException for 1., during the logback startup. This was the only place where I found the 1.. Changing it the build didn't fail in the same place, but will have to confirm what was the 1., and if the 1 alone will act the same way.
|
Fixed one broken test today, three more to go. Two I know the reason, but not the solution. The other we had during the migration mongo->postgres, so I just need to find the notes about how to debug that one (need to look at the query executed during the unit test...) |
…s as well, fixing tests.
Description
Upgrading to Spring Boot 3
Motivation and Context
#566 (comment)
Closes #576
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: