Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation checks for duplicate ids #56

Closed
tetron opened this issue Aug 25, 2016 · 4 comments
Closed

Validation checks for duplicate ids #56

tetron opened this issue Aug 25, 2016 · 4 comments

Comments

@tetron
Copy link
Member

tetron commented Aug 25, 2016

Validation should include a check that identifiers are not duplicated in a document.

@mr-c
Copy link
Member

mr-c commented Mar 7, 2017

Is this a "nice to have", or something we say in the spec?

@tetron
Copy link
Member Author

tetron commented Mar 9, 2017

I'm pretty sure this needs to be part of the spec. The document only has one namespace of identifiers.

@tetron
Copy link
Member Author

tetron commented Mar 10, 2017

Examples. These should fail validation by schema salad. Currently the 1st case eventually fails in cwltool (it should be caught earlier) the 2nd case doesn't get caught at all.

cwlVersion: v1.0
class: CommandLineTool
baseCommand: echo
inputs:
  - id: example_flag
    type: boolean
    inputBinding:
      position: 1
      prefix: -f
  - id: example_flag
    type: int
    inputBinding:
      position: 3
      prefix: --example-string

outputs: []

and

cwlVersion: v1.0
class: Workflow
inputs:
  example_flag:
    type: boolean
    inputBinding:
      position: 1
      prefix: -f

outputs: []

steps:
  example_flag:
    in: []
    out: []
    run: dup_id1.cwl

@kapilkd13
Copy link
Contributor

I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants