Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly draw graph when a workflow level input & output share the same name #99

Closed
mr-c opened this issue Apr 1, 2017 · 4 comments
Closed
Labels

Comments

@mr-c
Copy link
Member

mr-c commented Apr 1, 2017

https://view.commonwl.org/workflows/github.com/roryk/salmon-cwl/tree/master///salmon-workflow.cwl

See index in the linked workflow

@MarkRobbo
Copy link
Member

@mr-c Is this valid as a workflow under the rules of salad-schema?

I had a similar issue #56 earlier and closed it due to a discussion that this is technically possible in cwltool but is actually considered not valid.

@mr-c
Copy link
Member Author

mr-c commented Apr 3, 2017 via email

@MarkRobbo MarkRobbo added the bug label Apr 3, 2017
@MarkRobbo
Copy link
Member

MarkRobbo commented Jul 10, 2017

@mr-c I would like some clarification on this issue. In the current version of schema salad/cwltool the following error is thrown due to the "index" ID being reused

object id `https://cdn.rawgit.com/roryk/salmon-cwl/9772782d041c4d0a180fc89d55c83c31b24bb6af/salmon-workflow.cwl#index` previously defined

Is this a bug in cwltool or is this no longer considered valid?

@mr-c
Copy link
Member Author

mr-c commented Jul 10, 2017

Looks like the spec says "unique over the entire document", so an input and an output cannot share the same ID -- so I'll close this issue.

@mr-c mr-c closed this as completed Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants