Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for the example in CI #37

Open
17 of 21 tasks
tom-tan opened this issue Nov 10, 2017 · 6 comments
Open
17 of 21 tasks

Test for the example in CI #37

tom-tan opened this issue Nov 10, 2017 · 6 comments

Comments

@tom-tan
Copy link
Member

tom-tan commented Nov 10, 2017

It would be nice if there is a CI tester (such as Travis CI) for the examples in the user guide.
Such a scheme can keep the examples runnable for each commit.

Here is the list to solve this issue:

@tobyhodges
Copy link
Contributor

This would be great! Perhaps I can have a go at configuring such a thing...

@tom-tan
Copy link
Member Author

tom-tan commented Nov 29, 2017

How about using cwltest for this purpose?
It makes easier to maintain by using the existing framework.

To use cwltest for testing user guide, there are several issues to be solved:

  • In user guide, there are several examples that are expected to be failed (e.g. record.cwl and record-job1.yml in Section 11).
    It would be nice if cwltest can handle such cases.
  • Some examples just output the string as a side effect and return no results (e.g. record.cwl and record-job2.yml in Section 11). Also, some examples depend on the results of other examples in previous sections (e.g. tar.cwl in Section 4).
    It would be better to fix the examples to be testable, that is, fix them not to use side effects and to be independent each other.

If it is OK for this plan, I will make issues and pull requests for it later.

@tobyhodges
Copy link
Contributor

this sounds like a pretty good plan to me, though I do think that it would be good to keep examples where errors are expected. These are often good for people searching the web for an error message, and/or to demonstrate certain features e.g. dependent arguments/options.

what do you think, @mr-c?

@mr-c
Copy link
Member

mr-c commented Nov 29, 2017

Yes, we need to be able to have "known failure" testing, so a PR to adding that to cwltest would be very welcome!

@tom-tan
Copy link
Member Author

tom-tan commented Nov 30, 2017

Thank you for the reply.

Here is a todo list for this issue.

I will make PRs for them.

edited: I moved the above list to the first message.

@tom-tan
Copy link
Member Author

tom-tan commented Jan 9, 2019

As known in #63, the section for software requirement (it is reordered to the section 19) uses a large external tool.
To make the section 19 testable in CI, we have to replace the tool with smaller (or preferably containerized) one.

Unfortunately, it is difficult for me to fix this example because I am not good at bioinformatics tools...
Does anyone work to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants