Fix the example for section 09 not to use side effect #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
requested changes
Feb 21, 2018
| @@ -27,5 +27,8 @@ inputs: | |||
| separate: false | |||
| position: 4 | |||
|
|
|||
| outputs: [] | |||
| outputs: | |||
| output: | |||
There was a problem hiding this comment.
Please use a less generic name than output; people new to CWL will get confused as it looks similar to the CWL keyword outputs
There was a problem hiding this comment.
Thank you for your comment.
I will replace it with example_out.
|
(FYI, I edited the description of this PR; using the word "fixes" would auto-close the mentioned issues when the PR gets merged.) |
Thank you for the information. I will use other words from the next time. |
mr-c
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It partially addresses #37 and #62.