Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document more features of cwltool #246

Merged
merged 9 commits into from
Oct 10, 2022
Merged

Document more features of cwltool #246

merged 9 commits into from
Oct 10, 2022

Conversation

kinow
Copy link
Member

@kinow kinow commented Sep 5, 2022

Partially addresses #166

  • cwltool --make-template
  • cwltool --cachedir

For --make-template, I added a small paragraph to the Inputs section.

For --cachedir, I couldn't decide among prerequisites, FAQ, and a new section. In the end due to its length, I thought it would fit better in a new section for Troubleshooting (I imagine other devs have other interesting ways to troubleshoot CWL & cwltool execution). But happy to move it to somewhere else too.

@kinow kinow mentioned this pull request Sep 5, 2022
9 tasks
@kinow
Copy link
Member Author

kinow commented Sep 5, 2022

@mr-c, @tetron could you take a quick look before I continue working on this one?

For the --make-template, I think it fit well with the “Inputs” section https://common-workflow-languageuser-guide--246.org.readthedocs.build/en/246/topics/inputs.html#inp-job-yml (see the "Note" below the example linked).

For --cachedir, I created a separate “Troubleshooting” section: https://common-workflow-languageuser-guide--246.org.readthedocs.build/en/246/topics/troubleshooting.html#run-cwltool-with-cachedir

But I cannot find a good place in the existing sections for --parallel and --singularity. For --singularity I thought about an entry we have in the FAQ for CWL+singularity, https://common-workflow-languageuser-guide--246.org.readthedocs.build/en/246/faq.html#use-cwl-and-cwltool-with-singularity.

But still not sure if that's the best place to document the cwltool --singularity option.

Any thoughts?

Thanks!

@mr-c
Copy link
Member

mr-c commented Sep 12, 2022

for --parallel, that can be introduced as soon as there are steps that can be run independently

for --singularity & --podman, that can be introduced the first time we have a DockerRequirement; possibly users might want use CWLTOOL_OPTIONS to always set these options

@kinow
Copy link
Member Author

kinow commented Sep 13, 2022

Leaving the issue open, and partially addressing it with this PR 👍

@kinow kinow marked this pull request as ready for review September 13, 2022 02:27
@mr-c
Copy link
Member

mr-c commented Sep 20, 2022

@kinow ; now that #248 is merged, can you use the same technique here?

@kinow
Copy link
Member Author

kinow commented Sep 20, 2022

@kinow ; now that #248 is merged, can you use the same technique here?

Done. I believe I replaced all code blocks for commands with runcmd 👍 Thanks @mr-c

src/topics/troubleshooting.md Outdated Show resolved Hide resolved
mr-c
mr-c previously approved these changes Oct 10, 2022
src/_includes/cwl/troubleshooting/troubleshooting-wf1.cwl Outdated Show resolved Hide resolved

```{runcmd} cwltool --cachedir /tmp/cachedir/ troubleshooting-wf1.cwl
:working-directory: src/_includes/cwl/troubleshooting
:emphasize-lines: 12-14, 19-21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any effect of emphasize-lines with {runcmd}, alas (or at least, not on Read The Docs)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You arr correct. I actually had seen it and forgot to log an issue for that.

Runcmd extends the code block directive. It runs a command and then renders the code block.

It looks like the emphasize is applied before the code is rendered. So it gets ignored instead of highlighting the rendered command.

A bit tricky but I guess it could be one of those 1-line code fixes (that alas you spend more than you wanted on it 😅 )

@mr-c mr-c enabled auto-merge (squash) October 10, 2022 09:03
@mr-c mr-c merged commit 611c806 into main Oct 10, 2022
@mr-c mr-c deleted the show-more-of-cwltool branch October 10, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants