Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarity for installing dependencies and pip command for Graphviz #304

Conversation

AfiMaameDufie
Copy link
Contributor

@AfiMaameDufie AfiMaameDufie commented Oct 17, 2022

When I was setting up and going through the docs on CWL user_guide, I noticed these and would like to suggest these changes.

  • I added a comment and took out the [all] because I got a zsh: no matches found: .[all] and without the all it worked.

  • Second thing I did was to add the pip install for the Graphviz. Initially, I got dot command 'dot' cannot be run (needed for graphviz output), check the graphviz_dot setting and I proceeded to install Graphviz which seemed to solve the problem.

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AfiMaameDufie for these clarifications. I left some comments

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mr-c mr-c enabled auto-merge (squash) October 18, 2022 10:12
@mr-c mr-c merged commit 4d968b7 into common-workflow-language:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants