New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clarity for installing dependencies and pip command for Graphviz #304
Merged
mr-c
merged 7 commits into
common-workflow-language:main
from
AfiMaameDufie:Impr/Building_Section_in_the_CONTRIBUTION.md
Oct 18, 2022
Merged
Add clarity for installing dependencies and pip command for Graphviz #304
mr-c
merged 7 commits into
common-workflow-language:main
from
AfiMaameDufie:Impr/Building_Section_in_the_CONTRIBUTION.md
Oct 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
requested changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AfiMaameDufie for these clarifications. I left some comments
mr-c
reviewed
Oct 18, 2022
mr-c
reviewed
Oct 18, 2022
….com:AfiMaameDufie/user_guide into Impr/Building_Section_in_the_CONTRIBUTION.md
mr-c
requested changes
Oct 18, 2022
mr-c
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was setting up and going through the docs on CWL user_guide, I noticed these and would like to suggest these changes.
I added a comment and took out the [all] because I got a
zsh: no matches found: .[all]
and without theall
it worked.Second thing I did was to add the pip install for the Graphviz. Initially, I got
dot command 'dot' cannot be run (needed for graphviz output), check the graphviz_dot setting
and I proceeded to install Graphviz which seemed to solve the problem.