Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix record.cwl to make section 11 workable for record-job2.yml #35

Merged
merged 1 commit into from Nov 28, 2017

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented Oct 31, 2017

Currently an example record.cwl with record-job2.yml in section 11 does not return the same result as shown in the section.

Expected:
Section 11 shows that (itemC is chosen):

$ cwl-runner record.cwl record-job2.yml
[job 140566927111376] /home/example$ echo -A one -B two -C three
-A one -B two -C three
Final process status is success
{}

Actual (itemD is chosen):

$ cwl-runner record.cwl record-job2.yml
/Users/tom-tan/.pyenv/versions/3.6.2/bin/cwl-runner 1.0.20170908110401
Resolved 'record.cwl' to 'file:///Users/tom-tan/repos/user_guide/_includes/cwl/record.cwl'
[job record.cwl] /private/var/folders/gk/zyzswjbs6m59ywz69zhrtmlh0000gn/T/tmpgyqxniuj$ echo \
    -A \
    one \
    -B \
    two \
    -D \
    four
-A one -B two -D four
[job record.cwl] completed success
{}
Final process status is success

After merging this request:

$ cwl-runner record.cwl record-job2.yml
/Users/tom-tan/.pyenv/versions/3.6.2/bin/cwl-runner 1.0.20170908110401
Resolved 'record.cwl' to 'file:///Users/tom-tan/repos/user_guide/_includes/cwl/record.cwl'
record-job2.yml:6:3: invalid field `itemD`, expected one of: 'itemC'
[job record.cwl] /private/var/folders/gk/zyzswjbs6m59ywz69zhrtmlh0000gn/T/tmpef_u3_sk$ echo \
    -A \
    one \
    -B \
    two \
    -C \
    three
-A one -B two -C three
[job record.cwl] completed success
{}
Final process status is success

It shows the same command shown in the section. Also, latest cwl-runner prints a good warning for exclusive parameters.

Copy link
Contributor

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you @tom-tan. Sorry that it's taken me a month to get to this. I wonder if the formatting problem here is also affecting other .cwl files in the examples... 😟

@tobyhodges tobyhodges merged commit 0e29188 into common-workflow-language:gh-pages Nov 28, 2017
@tom-tan tom-tan deleted the fix-record branch November 29, 2017 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants