Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contribute): generate a CONTRIBUTING document #14

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

feat(contribute): generate a CONTRIBUTING document #14

wants to merge 13 commits into from

Conversation

gregswindle
Copy link
Collaborator

@gregswindle gregswindle commented Sep 30, 2017 •
edited

Description of change

Generate a CONTRIBUTING.md document based on guided assistance.

Associated issue(s)

Closes #10

  • The acceptance criteria for all associated issues have been completed, tested, and validated.

PR check-list

✅ Please review and check the appropriate items.

1. Code standards compliance

JavaScript Style Guide

  • ESLint passes.

2. Code quality Quality Gate

  • The quality gateways pass with an "A" grade.
Measure Scores
Complexity Complexity
Cognitive complexity
Complexity per Class
Complexity per file
Complexity per Function
Duplications Duplications
Issues Issues
Maintainability Code smells
Maintainability
Technical debt
Reliability Reliability
Security Security

3. Test coverage Coverage Status

  • The source code is 100% covered with passing specs.

ℹ️ These tasks are not required to open a PR, and may be addresses while the PR is open.

@gregswindle
build(packages): update dependencies
33060fd 
1. generator-node@2.3.0
2. markdown-magic@0.1.19
3. yeoman-generator@2.0.1
4. babel-jest@21.2.0
5. coveralls@2.13.3
6. eslint@4.8.0
7. eslint-plugin-jest@21.2.0
8. eslint-plugin-node@5.2.0
9. jest@21.2.1
10. jest-cli@21.2.1.
11. nsp@2.8.1

#10
@gregswindle
build(contribute): add initial resources
ad9b4c8 
#10
@gregswindle gregswindle self-assigned this Sep 30, 2017
@gregswindle gregswindle added this to In Progress in generator-community Sep 30, 2017
@gregswindle
docs(readme): simplify the Contributing section
2b7077b
@gregswindle
docs(contribute): revise and simplify
085995c
@gregswindle
build(security): update nested packages when possible
2fb2209 
1. 💡 Run npm --depth 20 update
2. Set snyk to ignore shelljs@0.7.8 for 30 days, as there's no fix in site

#10,#14
@gregswindle
fix(sonar rule S2424): fix overriden class
e2def09 
See https://sonarcloud.io/organizations/default/rules#rule_key=javascript%3AS2424

#10,#14
@gregswindle
docs(license): update license NOTICE
2448758 
#10,#14
@gregswindle
docs(changelog): add copy and goal
9c8218b 
#10,#14
@gregswindle
style(semicolon): remove code smell
3161a79 
#10,#14
@gregswindle
docs(readme): update contributing section
c2c3e5e 
#10,#14
@gregswindle
ci(snyk): only invoke snyk during travis builds
531842c 
Running snyk locally is exhausting my "private" licenses 😟

#10,#14
@gregswindle
test(license): achieve 100% coverage
f8bf58d 
#10,#14
@gregswindle
test(snyk): disable snyk
6a84f26 
Need to execute only in .travis.yml file, since it breaks
Appveyor builds.

#10,#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregswindle gregswindle

Labels
Priority: Medium Status: In Progress Type: Build Type: CI Type: Docs Type: Feature
Projects
generator-community
  
In Progress
Milestone
MVP4: community:contribute
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gregswindle