Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(product-manifest): extend generator-node:app #6

Merged
merged 4 commits into from
Sep 22, 2017

Conversation

gregswindle
Copy link
Collaborator

@gregswindle gregswindle commented Sep 22, 2017

Description of change

Generate:

  • .editorconfig
  • .gitattributes
  • .gitignore
  • LICENSE
  • package-lock.json
  • package.json

Initialize a (local) Git repository, too, if one doesn't exist.

Associated issue(s)

Closes #4

  • The acceptance criteria for all associated issues have been completed, tested, and validated.

PR check-list

✅ Please review and check the appropriate items.

1. Code standards compliance

JavaScript Style Guide

  • ESLint passes.

2. Code quality Quality Gate

  • The quality gateways pass with an "A" grade.
Measure Scores
Complexity Complexity
Cognitive complexity
Complexity per Class
Complexity per file
Complexity per Function
Duplications Duplications
Issues Issues
Maintainability Code smells
Maintainability
Technical debt
Reliability Reliability
Security Security

3. Test coverage Coverage Status

  • The source code is 100% covered with passing specs.

ℹ️ These tasks are not required to open a PR, and may be addresses while the PR is open.

Generate:
* .editorconfig
* .gitattributes
* .gitignore
* LICENSE
* package-lock.json
* package.json

Initialize a (local) Git repository, too, if one doesn't exist.

#4
@gregswindle
Copy link
Collaborator Author

Despite Appveyor's intransigents, I'm gonna merge in order to keep things moving along.

@gregswindle gregswindle merged commit 12fba11 into master Sep 22, 2017
@gregswindle gregswindle deleted the feat/#4-product-manifest branch September 22, 2017 05:54
@codecov-io
Copy link

codecov-io commented Sep 22, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@0e539d0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #6   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?     30           
  Branches          ?      6           
=======================================
  Hits              ?     30           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
generators/app/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e539d0...be5f92d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants