Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code-of-conduct): generate a CODE_OF_CONDUCT.md file #9

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

gregswindle
Copy link
Collaborator

@gregswindle gregswindle commented Sep 26, 2017

Description of change

Generate a CODE_OF_CONDUCT.md file.

Associated issue(s)

Closes #8

  • The acceptance criteria for all associated issues have been completed, tested, and validated.

PR check-list

✅ Please review and check the appropriate items.

1. Code standards compliance

JavaScript Style Guide

  • ESLint passes.

2. Code quality Quality Gate

  • The quality gateways pass with an "A" grade.
Measure Scores
Complexity Complexity
Cognitive complexity
Complexity per Class
Complexity per file
Complexity per Function
Duplications Duplications
Issues Issues
Maintainability Code smells
Maintainability
Technical debt
Reliability Reliability
Security Security

3. Test coverage Coverage Status

  • The source code is 100% covered with passing specs.

ℹ️ These tasks are not required to open a PR, and may be addresses while the PR is open.

@gregswindle
Copy link
Collaborator Author

SonarQube analysis reported 1 issue

  • MINOR 1 minor

Watch the comments in this conversation to review them.

this.options
)
}
};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Remove this empty statement. rule

Copy link
Collaborator Author

@gregswindle gregswindle Sep 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement is required in order to provide a contact email.

💯 SonarCloud's test coverage appears to be erroneous: Istanbul and Coveralls report 100% coverage.

@gregswindle gregswindle merged commit bcb8efe into master Sep 26, 2017
@gregswindle gregswindle deleted the feat/#8-conduct branch September 26, 2017 11:24
@gregswindle gregswindle added this to Completed in generator-community Sep 26, 2017
@gregswindle gregswindle restored the feat/#8-conduct branch September 27, 2017 21:38
@gregswindle gregswindle deleted the feat/#8-conduct branch September 27, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant