Add test for setupHiddenBot

commonlispbr · Jul 28, 2020 · 7acb3b9 · 7acb3b9
1 parent 1398ef0
commit 7acb3b9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 13 deletions.
diff --git a/troll_shield.go b/troll_shield.go
@@ -196,24 +196,26 @@ func setupBot(envVar string) (*telegram.BotAPI, error) {
 	return bot, nil
 }
 
-func setupBots() (*telegram.BotAPI, *telegram.BotAPI, error) {
-	var bot, botHidden *telegram.BotAPI
-	var err error
-
-	log.Println("Setup the main bot")
-	bot, err = setupBot("TELEGRAM_BOT_TOKEN")
-	if err != nil {
-		return nil, nil, err
-	}
-
+func setupHiddenBot(bot *telegram.BotAPI) *telegram.BotAPI {
 	log.Println("Setup the hidden bot")
-	botHidden, err = setupBot("TELEGRAM_BOT_HIDDEN_TOKEN")
+	botHidden, err := setupBot("TELEGRAM_BOT_HIDDEN_TOKEN")
 	if err != nil {
 		log.Printf("Bot setup failed: %v. Fallback to main bot.", err)
 		botHidden = bot
 	}
 
-	return bot, botHidden, nil
+	return botHidden
+
+}
+
+func setupBots() (*telegram.BotAPI, *telegram.BotAPI, error) {
+	log.Println("Setup the main bot")
+	bot, err := setupBot("TELEGRAM_BOT_TOKEN")
+	if err != nil {
+		return nil, nil, err
+	}
+
+	return bot, setupHiddenBot(bot), nil
 }
 
 func leaveChat(bot TrollShieldBot, update *telegram.Update, trollGroup string) {

diff --git a/troll_shield_test.go b/troll_shield_test.go
@@ -174,9 +174,14 @@ func TestSetupBot(t *testing.T) {
 }
 
 func TestSetupBots(t *testing.T) {
-	if _, _, err := setupBots(); err == nil {
+	bot, _, err := setupBots()
+	if err == nil {
 		t.Errorf("setupBots fail with invalid tokens.")
 	}
+	botHidden := setupHiddenBot(bot)
+	if botHidden != bot {
+		t.Errorf("When botHidden fails to start, use bot as fallback")
+	}
 }
 
 func TestSetupLogging(t *testing.T) {