Disable welcomeMessage for non-banned join #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now only when pass system is used the welcomeMessage is triggered. When the pass system is used it's important to ensure the read of rules, I think. The behavior to print the welcomeMessage after each non-banned user can be annoying because a lot of them are bots. join_captcha_bot will erase that messages, but the welcomeMessages from our bot will remains. That creates a lot of noises on the group.
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 1 1
Lines 181 181
=======================================
Hits 171 171
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now only when pass system is used the welcomeMessage is triggered. When the pass system is used it's important to ensure the read of rules, I think.
The behavior to print the welcomeMessage after each non-banned user can be annoying because a lot of them are bots. join_captcha_bot will erase that messages, but the welcomeMessages from our bot will remains.
That creates a lot of noises on the group.