Add /kills command with save state functionality #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG: - Kills state it's loaded at session start, if doesn't exists set to 0. - Kills state it's saved on the file kills.txt - Kills state it's saved after each ban, to ensure being saved. - If /kills it's called will report the current kills state.
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
===========================================
+ Coverage 78.98% 93.52% +14.53%
===========================================
Files 1 1
Lines 138 139 +1
===========================================
+ Hits 109 130 +21
+ Misses 29 9 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Important fix: os.O_TRUNC should be set as flag in os.OpenFile to overwrite the kills.txt file properly. Otherwise, ff the kills.txt had initially "random-fuckups", writing 10 will turn out in: "10ndom-fuckups". This is not the intended behavior.
This will make more easier to control the unit tests, since main is not possible to test.
mateusfccp
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
/killsit's called will report the current kills state.