Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only remove users instead ban: give a chance #9

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

ryukinix
Copy link
Member

@ryukinix ryukinix commented Aug 10, 2020

Make lelerax more merciful: a kicked person can now try again.
This make sense since we have a /pass option. After giving the pass,
the user can try again without bothering about unban the user anymore.
This now will be the default behavior.

@ryukinix
Copy link
Member Author

ryukinix commented Aug 10, 2020

Codecov Report

Merging #9 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   94.08%   94.15%   +0.06%     
==========================================
  Files           1        1              
  Lines         169      171       +2     
==========================================
+ Hits          159      161       +2     
  Misses         10       10              
Flag Coverage Δ
#unittests 94.15% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
troll_shield.go 94.15% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5931fc6...228ec11. Read the comment docs.

@@ -166,7 +172,7 @@ func kickTroll(bot TrollShieldBot, update *telegram.Update, user telegram.User,
} else {
username := getUserName(user)
text := fmt.Sprintf(
"%v foi banido porque é membro do grupo: %v. Adeus.",
"%v foi removido porque é membro do grupo: %v. Para mais informações, acione o nosso SAC 24h: @skhaz.",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luksamuk
Copy link
Member

luksamuk commented Aug 10, 2020

O SAC foi uma adição maravilhosa

@ryukinix ryukinix changed the title Remove users: give a chance to try again Only remove users instead ban: give a chance to try again Aug 11, 2020
@ryukinix ryukinix changed the title Only remove users instead ban: give a chance to try again Only remove users instead ban: give a chance Aug 11, 2020
Make lelerax more merciful: a kicked person can now try again.
This make sense since we have a /pass option. After giving the pass,
it can try again without bothering about unban the user anymore. This
is the default behavior.
@ryukinix ryukinix merged commit 8888d72 into master Aug 11, 2020
@ryukinix ryukinix deleted the feature/remove-not-ban branch August 11, 2020 00:42
@ryukinix
Copy link
Member Author

Maybe that was not a good idea.

@ryukinix
Copy link
Member Author

image

@ryukinix
Copy link
Member Author

Maybe we'll need to revert that change.

ryukinix added a commit that referenced this pull request Aug 11, 2020
ryukinix added a commit that referenced this pull request Aug 11, 2020
Revert "Merge pull request #9 from commonlispbr/feature/remove-not-ban"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants