Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delimiter type of bulleted list #201

Closed
kapyshin opened this issue May 29, 2017 · 2 comments
Closed

Delimiter type of bulleted list #201

kapyshin opened this issue May 29, 2017 · 2 comments

Comments

@kapyshin
Copy link
Contributor

While testing cmark_node_get_list_delim I noticed that it returns CMARK_PERIOD_DELIM for bulleted list. This was a bit unexpected (CMARK_NO_DELIM seems natural). Should it be this way?

JavaScript implementation gives null in such case:

> reader.parse("* one\n* two\n\n").firstChild.listType
< "bullet"
> reader.parse("* one\n* two\n\n").firstChild.listDelimiter
< null
@nwellnhof
Copy link
Contributor

Looks like a bug. This line should probably be removed, or changed to initialize with CMARK_NO_DELIM.

@jgm
Copy link
Member

jgm commented May 30, 2017 via email

@jgm jgm closed this as completed in 58b37ae May 30, 2017
kapyshin added a commit to kapyshin/paka.cmark that referenced this issue May 30, 2017
Now that commonmark/cmark#201 is fixed,
cmark correctly returns CMARK_NO_DELIM for bulleted lists.
phillmv added a commit to eli-schwartz/cmark that referenced this issue Jan 31, 2023
[Autolink] Store positioning info for url_match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants