Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFI bindings #60

Closed
txdv opened this issue Jun 23, 2015 · 4 comments · Fixed by #61
Closed

FFI bindings #60

txdv opened this issue Jun 23, 2015 · 4 comments · Fixed by #61

Comments

@txdv
Copy link
Contributor

txdv commented Jun 23, 2015

Hey guys, I saw that the version strings are external symbols to variables.

Some programming languages support only ffi, as in, all external calls can be made only through functions, variables are not accessible even if they are external, for example C#.

Could we get additional functions to retrieve the version string and integer number?
@jgm
Copy link
Member

jgm commented Jun 23, 2015

Makes sense to me. And maybe the variable isn't needed if we have a function. What do you think, @nwellnhof ?

@nwellnhof
Copy link
Contributor

Yes, we should add these functions to support bindings based on FFI. We could also remove the global version variables then. I'd like to keep the version macros, though.

@jgm
Copy link
Member

jgm commented Jun 24, 2015 via email

@txdv
Copy link
Contributor Author

txdv commented Jun 25, 2015

I will make a pull request then.

txdv added a commit to txdv/cmark that referenced this issue Jun 25, 2015
@txdv
Changed version variables to functions.
7b91f44 
This is easier to access using ffi, since some languages, like C#
like to use only function interfaces for accessing library
functionality.

fixes commonmark#60
@txdv txdv mentioned this issue Jun 25, 2015
Merged
txdv added a commit to txdv/cmark that referenced this issue Jun 25, 2015
@txdv
Changed version variables to functions.
06b355f 
This is easier to access using ffi, since some languages, like C#
like to use only function interfaces for accessing library
functionality.

fixes commonmark#60
@jgm jgm closed this as completed in #61 Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed version variables to functions. txdv/cmark
3 participants
@jgm @nwellnhof @txdv