Fix NUL-LF sequence lex #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I may make some minor changes to this. |
jgm
added a commit
that referenced
this pull request
Oct 11, 2016
- only check once for "not at end of line" - check for null before we check for newline characters (the previous patch would fail for NULL + CR) See #160.
|
Looks good! Although the spacing seems to have gone slightly awry. |
|
I think I fixed the spacing in the next commit. (I updated 'make format' so it doesn't reimport imports, +++ Yuki Izumi [Oct 11 16 07:20 ]:
|
CyberShadow
pushed a commit
to CyberShadow/cmark
that referenced
this pull request
Apr 1, 2021
…s_tasklist_state_is_checked (commonmark#161) This is in response to issue commonmark#160. This removes cmark_gfm_extensions_get_tasklist_state and adds the new cmark_gfm_extensions_tasklist_state_is_checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159.
If we hit a NUL, we advance past it. But then we advance past any LF or CR-LF, assuming we're at the end of a line and just need to push past the newline that broke us from the loop.