Fixes for the LaTeX renderer #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2017 17:10
\- is a hyphenation, so it doesn't get displayed at all.
jgm
reviewed
Jan 7, 2017
| @@ -389,7 +389,6 @@ static int S_render_node(cmark_renderer *renderer, cmark_node *node, | |||
| switch (get_link_type(node)) { | |||
| case URL_AUTOLINK: | |||
| LIT("\\url{"); | |||
| OUT(url, false, URL); | |||
There was a problem hiding this comment.
This fixes the double rendering, but we lose proper escaping for the URL. (That is what the URL in OUT accomplishes.) The correct fix would be to keep this line and somehow suppress the output of children of this node. To do this, return 0 (that stops processing of the contents of the node):
- break;
+ LIT("}");
+ return 0; // don't process contents or we get double render
There was a problem hiding this comment.
Ah, ok.
I've improved this in 1c0d474. Thanks for looking over it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first fix corrects ligature handling with dashes, (- are manual hyphenations), the second fixes a double-output of urls.