Explicitly add -fPIC for static library
#39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Debian 8.x (jessie) with CMake 3.0.2 was released, so we can use |
|
It looks like you can conditionalize on cmake version. |
|
Ah, you're right, we are requiring 2.8.9 now. So, no reason not to just add this. |
PKRoma
pushed a commit
to PKRoma/cmark
that referenced
this pull request
Aug 19, 2018
A UBSAN warning can be triggered when handling a long sequence of backticks: src/commonmark.c:98:20: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' which can be triggered by: ``` | a | b | | --- | --** `c```````````````````````````````- | | c | `|d` \| e | ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not very well acquainted with how
cmakeworks. Many resources online indicate that-fPICis set by default when building a static library.However, I'm finding that's not the case. When trying to natively calls some Houdini methods in gjtorikian/commonmarker#5, the CI runs into linking issues. Setting this flag explicitly resolves these issues.
Perhaps when
COMPILE_FLAGSis redefined it overrides the default-fPICsetting?