Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut reference link with paren after it #427

Closed
dikmax opened this issue Aug 15, 2016 · 1 comment
Closed

Shortcut reference link with paren after it #427

dikmax opened this issue Aug 15, 2016 · 1 comment

Comments

@dikmax
Copy link
Contributor

dikmax commented Aug 15, 2016

Consider this example:

[link](Some text, not link)

[link]: asdf

Spec says:

A shortcut reference link consists of a link label that matches a link reference definition elsewhere in the document and is not followed by [] or a link label. The contents of the first link label are parsed as inlines, which are used as the link’s text. The link’s URI and title are provided by the matching link reference definition. Thus, [foo] is equivalent to [foo][].

It looks like the example above should be a link, but it doesn't. I think we should add an explanation to spec why not, or fix commonmark.js if it should be parsed that way.
@jgm
Copy link
Member

jgm commented Sep 15, 2016

I'm calling this an implementation bug.

@jgm jgm closed this as completed in cfc8416 Sep 15, 2016
jgm added a commit to commonmark/cmark that referenced this issue Sep 15, 2016
@jgm
Allow a shortcut link before a (.
53ef343 
See commonmark/commonmark-spec#427
jgm added a commit to commonmark/commonmark.js that referenced this issue Sep 15, 2016
@jgm
Allow shortcut link before a (.
2270a73 
See commonmark/commonmark-spec#427.
colinodell added a commit to thephpleague/commonmark that referenced this issue Nov 22, 2016
@colinodell
Parse h2-h6 as block elements (see commonmark/commonmark-spec#427)
a885f32
colinodell added a commit to thephpleague/commonmark that referenced this issue Nov 22, 2016
@colinodell
Allow shortcut link before an open paren (see commonmark/commonmark-s…
f391b62 
…pec#427)
ujifgc added a commit to ujifgc/markdown-it that referenced this issue Nov 27, 2016
@ujifgc
fallback to reference if a link is not valid
8b71bf1 
This commit makes martdown-it pass a new example introduced in commonmark/commonmark-spec@cfc8416

```
[foo](not a link)

[foo]: /url1
.
<p><a href="/url1">foo</a>(not a link)</p>
```

Ref: commonmark/commonmark-spec#427
ujifgc added a commit to ujifgc/markdown-it that referenced this issue Nov 27, 2016
@ujifgc
fallback to reference if a link is not valid
c3a7f9a 
This commit makes martdown-it pass a new example introduced in commonmark/commonmark-spec@cfc8416

```
[foo](not a link)

[foo]: /url1
.
<p><a href="/url1">foo</a>(not a link)</p>
```

Ref: commonmark/commonmark-spec#427
@ujifgc ujifgc mentioned this issue Nov 27, 2016
Merged
@robinst robinst mentioned this issue Nov 29, 2016
Closed
2 tasks
rlidwka pushed a commit to markdown-it/markdown-it that referenced this issue Nov 30, 2016
@ujifgc @rlidwka
fallback to reference if a link is not valid
5e78016 
This commit makes martdown-it pass a new example introduced in commonmark/commonmark-spec@cfc8416

```
[foo](not a link)

[foo]: /url1
.
<p><a href="/url1">foo</a>(not a link)</p>
```

Ref: commonmark/commonmark-spec#427
rlidwka pushed a commit to markdown-it/markdown-it that referenced this issue Nov 30, 2016
@ujifgc @rlidwka
fallback to reference if a link is not valid
ebc9f50 
This commit makes martdown-it pass a new example introduced in commonmark/commonmark-spec@cfc8416

```
[foo](not a link)

[foo]: /url1
.
<p><a href="/url1">foo</a>(not a link)</p>
```

Ref: commonmark/commonmark-spec#427
jmalarcon pushed a commit to jmalarcon/markdown-it that referenced this issue Jan 13, 2017
@ujifgc @jmalarcon
fallback to reference if a link is not valid
6b77146 
This commit makes martdown-it pass a new example introduced in commonmark/commonmark-spec@cfc8416

```
[foo](not a link)

[foo]: /url1
.
<p><a href="/url1">foo</a>(not a link)</p>
```

Ref: commonmark/commonmark-spec#427
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue May 23, 2017
Updated textproc/cmark 0.26.1 to 0.27.1
2f18532 
---------------------------------------
cmark 0.27.1
 jgm released this on 19 Nov 2016 揃 46 commits to master since this release

 -  Set policy for CMP0063 to avoid a warning (#162).
    Put set_policy under cmake version test.
    Otherwise we get errors in older versions of cmake.
 -  Use VERSION_GREATER to clean up cmake version test.
 -  Improve afl target. Use afl-clang by default. Set default for path.

cmark 0.27.0
 jgm released this on 19 Nov 2016 揃 49 commits to master since this release

 -  Update spec to 0.27.
 -  Fix warnings building with MSVC on Windows (#165, Hugh Bellamy).
 -  Fix CMAKE_C_VISIBILITY_PRESET for cmake versions greater than 1.8
    (e.g. 3.6.2) (#162, Hugh Bellamy). This lets us build swift-cmark
    on Windows, using clang-cl.
 -  Fix for non-matching entities (#161, Yuki Izumi).
 -  Modified print_delimiters (commented out) so it compiles again.
 -  make format: don't change order of includes.
    Changed logic for null/eol checks (#160).
    * only check once for "not at end of line"
    * check for null before we check for newline characters (the
      previous patch would fail for NULL + CR)
 -  Fix by not advancing past both \0 and \n (Yuki Izumi).
 -  Add test for NUL-LF sequence (Yuki Izumi).
 -  Fix memory leak in list parsing (Yuki Izumi).
 -  Use cmark_mem to free where used to alloc (Yuki Izumi).
 -  Allow a shortcut link before a ( (commonmark/commonmark-spec#427).
 -  Allow tabs after setext header line (commonmark/commonmark.js#109).
 -  Don't let URI schemes start with spaces.
 -  Fixed h2..h6 HTML blocks (commonmark/commonmark-spec#430). Added regression test.
 -  Autolink scheme can contain digits (Gábor Csárdi)
 -  Fix nullary function declarations in cmark.h (Nick Wellnhofer).
 -  Fixes strict prototypes warnings.
 -  COPYING: Update file name and remove duplicate section and
     (Peter Eisentraut).
 -  Fix typo (Pavlo Kapyshin).
talum pushed a commit to github/cmark-gfm that referenced this issue Sep 14, 2021
@jgm
Allow a shortcut link before a (.
d04b1e8 
See commonmark/commonmark-spec#427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgm @dikmax