New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named HTML entities with multiple codepoints not parsed correctly #47
Comments
I see that in cmark, In commonmark.js, In commonmark.js, there is the further problem that the I agree that a case like this should be in the spec, too. +++ Robin Stocker [Jun 13 15 01:11 ]:
|
Removed html5-entities.js. Added dependency on entities in package.json. This fixes the problem reported in #47, but I want to keep that issue open until cmark and the spec are also fixed.
The old one had many errors. The new one is derived from the list in the npm entities package. Since the sequences can now be longer (multi-code-point), we have bumped the length limit from 4 to 8, which also affects houdini_html_u.c. An example of the kind of error that was fixed in given in commonmark/commonmark.js#47: `≧̸` should be rendered as "≧̸" (U+02267 U+00338), but it's actually rendered as "≧" (which is the same as `≧`).
Put entity tests on several lines for readability. See commonmark/commonmark.js#47.
OK, everything should be fixed now! Thanks for pointing out the problem. |
Thanks for the quick reaction! :) |
The old one had many errors. The new one is derived from the list in the npm entities package. Since the sequences can now be longer (multi-code-point), we have bumped the length limit from 4 to 8, which also affects houdini_html_u.c. An example of the kind of error that was fixed in given in commonmark/commonmark.js#47: `≧̸` should be rendered as "≧̸" (U+02267 U+00338), but it's actually rendered as "≧" (which is the same as `≧`).
See the following example: http://spec.commonmark.org/dingus/?text=%26ngE%3B%0A%0A%26gE%3B
≧̸
should be rendered as "≧̸" (U+02267 U+00338), but it's actually rendered as "≧" (which is the same as≧
)It looks like other such named entities are also not handled correctly.
Would probably also be good to add such an entity to the spec so that implementations are checked for this.
The text was updated successfully, but these errors were encountered: