Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method 2 bug in office 365 params #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joepagan
Copy link

Wrapping short hand conditional in brackets otherwise will result in &location=true

'&location=' + (event.address || ''),
'&allday=' + (event.allday)?'true':'false'

will result in &location=,true which later turns into &location=true

wrapping the allday shorthand conditional in brackets returns it correctly as: &location=&allday=true

@commonpike
Copy link
Owner

all nice work joe, thanks ! - I have no time to test & merge it now, but it all looks good, keep it up !

@joepagan
Copy link
Author

joepagan commented Sep 17, 2020

Thanks, no problem & no pressure as using a local version that I've manipulated on a project I've been looking at and this isn't under a package manager (That I know of?)

just FYI, I haven't re-built the minified file on this & the other PR, not sure how you are handling that so didn't want to touch until I knew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants