Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orientation change in NearbyActivity causes it to reinitialise NearbyListFragment. #1180

Closed
knight-shade opened this issue Feb 23, 2018 · 1 comment
Closed

Orientation change in NearbyActivity causes it to reinitialise NearbyListFragment. #1180

knight-shade opened this issue Feb 23, 2018 · 1 comment

Comments

@knight-shade
Copy link
Contributor

knight-shade commented Feb 23, 2018 •
edited

Summary:

When there occurs a orientation change in NearybyActivty, it reinitialise the NearbyListFragment and reloads the data again.

Steps to reproduce:

  1. Go Nearby Places activity from navigation drawer.
  2. Load the list of nearby places as shown below:

nearby places list

  1. Change the orientation of phone.

Expected behavior:

Change in orientation should check whether there already exists a instance of NearbyListFragment,
if not, then only a new instance of NearbyListFragment should be created.

Observed behavior:

During orientation change in NearybyActivty, it reinitialise the NearbyListFragment.

I am working on the issue.

Update
Issue has been fixed.
knight-shade added a commit to knight-shade/apps-android-commons that referenced this issue Feb 25, 2018
@knight-shade
Changes in NearybyActivity prevents reinitialising of NearybyFragment…
5729262 
… if it already exists.

Fixes commons-app#1180
knight-shade added a commit to knight-shade/apps-android-commons that referenced this issue Feb 25, 2018
@knight-shade
1.Changes in NearybyActivity prevents reinitialising of NearybyFragme…
125b21f 
…nt if it already exists.

2.Upgraded robolectric from 3.4 to 3.7.1 to solve known issue(AndroidManifest not found).
Fixes commons-app#1180
knight-shade added a commit to knight-shade/apps-android-commons that referenced this issue Feb 25, 2018
@knight-shade
1.Changes in NearybyActivity prevents reinitialising of NearybyFragme…
058052a 
…nt if it already exists.

2.Upgraded robolectric from 3.4 to 3.7.1 to solve known issue(AndroidManifest not found).
Fixes commons-app#1180
@knight-shade knight-shade mentioned this issue Feb 25, 2018
Closed
@neslihanturan
Copy link
Collaborator

This seems solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neslihanturan @knight-shade