Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ItemDivider in NearbyListFragment #1205

Closed
knight-shade opened this issue Feb 26, 2018 · 1 comment
Closed

Add ItemDivider in NearbyListFragment #1205

knight-shade opened this issue Feb 26, 2018 · 1 comment

Comments

@knight-shade
Copy link
Contributor

Summary:

Currently, There is no ItemDivider used in the NearbyListFragment. adding an ItemDivider will make it look cleaner and will help users to understand how the content is organized.

Steps to reproduce:

  1. Go to nearby from navigation drawer.
  2. Select list mode.

Expected behavior:
after

Observed behavior:
before

I have made a fix, creating PR very soon.
knight-shade added a commit to knight-shade/apps-android-commons that referenced this issue Feb 26, 2018
@knight-shade
Add DividerItemDecoration to add ItemDivider in RecycleView in Nearby…
7754b73 
…ListFragment.

Fixes commons-app#1205
@knight-shade knight-shade mentioned this issue Feb 26, 2018
Closed
@maskaravivek
Copy link
Member

maskaravivek commented Feb 26, 2018 •
edited

Duplicate of #1186.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maskaravivek @knight-shade