Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper width of Navigation drawer #1275

Closed
knight-shade opened this issue Mar 10, 2018 · 2 comments
Closed

Set proper width of Navigation drawer #1275

knight-shade opened this issue Mar 10, 2018 · 2 comments

Comments

@knight-shade
Copy link
Contributor

Summary:

The width of navigation drawer in portrait mode seems to be more then appropriate and creates feeling of emptiness or like something is missing in navigation drawer. This is more prominent in landscape mode where navigation drawer covers 70% of screen and most of it is empty.

Screen-shots:

Observed

Portrait
pb

Landscape
lb

Excepted

Portrait
pa

Landscape
la

What do you think? @maskaravivek @nicolas-raoul
@maskaravivek
Copy link
Member

Looks good to me. If you want to pick it up, please go ahead with it. :)

@knight-shade
Copy link
Contributor Author

Sure @maskaravivek I will create PR for this issue.

knight-shade added a commit to knight-shade/apps-android-commons that referenced this issue Mar 11, 2018
@knight-shade
Sets the proper width to Navigation drawer in portrait and landscape …
4861c4d 
…mode.

Fixes commons-app#1275
This was referenced Mar 11, 2018
Merged
Closed
neslihanturan added a commit that referenced this issue Mar 16, 2018
@neslihanturan
Merge pull request #1279 from knight-shade/Fixes-#1275
ce8c807 
Fixes #1275 Set proper with of Navigation drawer in both orientations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maskaravivek @knight-shade