Limit on number of images uploaded at once

[ilgazer]

Summary:

For multiple uploads, there should be an upper limit on the number of images a user can upload at a time. From #604 :

We need to enforce the limit on the number of images that can be uploaded at one go on our own.

One suggestion is to have this check in the 1st step of the upload flow itself. If the user has selected more than 5 images, he will need to remove the extra ones before proceeding.

The top bar can have a close icon to remove an image before proceeding. The user can simply remove any image before proceeding.

[harith96]

If this issue is not assigned to anyone, I would like to look into the matter

[nicolas-raoul]

@harith96 Thanks! :-)

[harith96]

I've implemented the feature and am currently improving the code and adding javadocs. There are several small new functions as I've used existing functions for the most part. Should I write unit tests for the new ones?

[ilgazer]

That's great to hear :) You indeed need to write tests for your code. Keep in mind that the focus is to test the feature, it's up to you to find the best way to do that.

…

On Aug 9, 2019 7:21 AM, "harith96" ***@***.***> wrote: I've implemented the feature and am currently improving the code and adding javadocs. There are several small new functions as I've used existing functions for the most part. Should I write unit tests for the new ones? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3101?email_source=notifications&email_token=AB2EXI2SIUAYODHBU26XH5DQDTWFBA5CNFSM4IH3FV6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD35RLMQ#issuecomment-519771570>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB2EXI24BHPZZUBF5YK7UO3QDTWFBANCNFSM4IH3FV6A> .

[neslihanturan]

There is a sleeping PR almost ready for this issue: #3124 . If anyone interested this issue, please make sure you checked the code at mentioned PR.

[u7469570]

Hi, is this issue still relevant? If so, I'd be interested in pursuing it as a first foray into open source for a university project.

[nicolas-raoul]

@u7469570 Yes still relevant, just replace 5 with 20 as upload reliability has improved. 🙂

[nicolas-raoul]

Thanks @u7469570 for fixing the issue in the custom selector!

The next steps would be to do the same with the normal picker, and with the share intent. For these two, I guess the only thing we can do is to keep only the first 20 uploads, and show the same popup (implemented by @u7469570) explaining why we do this.

@u7469570 I unassigned you but of course if you want to also implement the above then you are more than welcome, I can assign you again if you ask. :-)