Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crash in CategoryDetailsActivity when click on any media #4196

Closed
Prince-kushwaha opened this issue Jan 21, 2021 · 6 comments · Fixed by #4233
Closed

App crash in CategoryDetailsActivity when click on any media #4196

Prince-kushwaha opened this issue Jan 21, 2021 · 6 comments · Fixed by #4233
Assignees
Labels

Comments

@Prince-kushwaha
Copy link
Contributor

Prince-kushwaha commented Jan 21, 2021

Summary:
In the CategoryDetalis Activity click on any medai (image or video) then App crash

Steps to reproduce:
See in ScreenShot

What did you expect the app to do, and what did you see instead?
App not crash in the CategoryDetails Activity on click on any medai (image,video)

System logs:

java.lang.NullPointerException: Attempt to invoke virtual method 'void androidx.appcompat.app.ActionBar.setDisplayHomeAsUpEnabled(boolean)' on a null object reference
at fr.free.nrw.commons.media.MediaDetailPagerFragment.onCreateView(MediaDetailPagerFragment.java:103)
at androidx.fragment.app.Fragment.performCreateView(Fragment.java:2698)
at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:310)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1185)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1354)
at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1432)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1495)
at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:447)
at androidx.fragment.app.FragmentManager.executeOps(FragmentManager.java:2167)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1990)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1945)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1847)
at androidx.fragment.app.FragmentManager.executePendingTransactions(FragmentManager.java:489)
at fr.free.nrw.commons.category.CategoryDetailsActivity.onMediaClicked(CategoryDetailsActivity.java:122)
at fr.free.nrw.commons.explore.media.PageableMediaFragment$pagedListAdapter$2$1.invoke(PageableMediaFragment.kt:17)
at fr.free.nrw.commons.explore.media.PageableMediaFragment$pagedListAdapter$2$1.invoke(PageableMediaFragment.kt:14)
at fr.free.nrw.commons.explore.media.SearchImagesViewHolder$bind$1.onClick(PagedMediaAdapter.kt:37)

Device and Android version:
Android Device:Redmi y3

Commons app version:
Latest Master

Screen-shots:

Screenrecorder-2021-01-21-09-55-50-1.mp4

Would you like to work on the issue?
YES
Please let us know whether you want to fix the issue by yourself. If not, anyone can get the issue assigned to them.
YES

@Prince-kushwaha
Copy link
Contributor Author

Can I work on this issue

@madhurgupta10
Copy link
Collaborator

@Prince-kushwaha Thanks for reporting the issue, feel free to work on it.

@mrudultora
Copy link
Contributor

@Prince-kushwaha Are you still working on this ? If not, then please inform :-)

@Prince-kushwaha
Copy link
Contributor Author

@mrudultora I am work on this issue

@mrudultora
Copy link
Contributor

@Prince-kushwaha Okay ;-)

@Prince-kushwaha Prince-kushwaha changed the title App crash in CategoryDetailsActivity App crash in CategoryDetailsActivity when click on any medai Feb 16, 2021
@Prince-kushwaha Prince-kushwaha changed the title App crash in CategoryDetailsActivity when click on any medai App crash in CategoryDetailsActivity when click on any media Feb 16, 2021
@nicolas-raoul
Copy link
Member

I am able to reproduce the crash on latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants