Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: App Crashes when Switched Between Dark/Light Mode in Location Picker Activity #5474

Closed
shashankiitbhu opened this issue Jan 24, 2024 · 4 comments · Fixed by #5500
Closed
Assignees
Labels

Comments

@shashankiitbhu
Copy link
Contributor

Summary

The App Crashes when you switch between Light/Dark mode on your device in the Location Picker Activity. I believe it will crash in any Configuration change on your device, Like changing Font-size Similar to issue #5437 opened by @nicolas-raoul , I think we need to handle configuration change for this activity , I will be doing that in my next PR

Steps to reproduce

  1. Open the App
  2. Go to any of your Contributions
  3. Select Edit Location Icom
  4. Switch Between Light/Dark Mode on your Device

Expected behaviour

App Should not Crash

Actual behaviour

App Crashes

Device name

Xaomi 11 Lite NE

Android version

13

Commons app version

4.2.1-debug-main

Device logs

No response

Screen-shots

WhatsApp.Video.2024-01-24.at.3.41.43.PM.mp4

Would you like to work on the issue?

Yes

@rohit9625
Copy link
Contributor

Yes you are right. It's crashing.

@geektan123
Copy link

Assign #5474

@shashankiitbhu
Copy link
Contributor Author

I am already working on this as Indicated in OP, @nicolas-raoul can you look at this bug and assign it to me, thanks

@shashankiitbhu
Copy link
Contributor Author

@nicolas-raoul Please Review the above PR, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants