New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only the email clients in Feedback Feature (#1203) #1204

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
4 participants
@ayushin78
Contributor

ayushin78 commented Feb 25, 2018

Description

Fixes #1203

Instead of showing only the email clients, The Feedback feature was showing multiple unsupported clients (WhatsApp, Bluetooth etc). Changes made to display only the email clients.

Screenshots showing what changed

Before After
screenshot_20180226-031109 1 screenshot_20180226-032658 1
Show only the email clients in Feedback Feature (#1203)
Instead of showing only the email clients, The Feedback feature was showing multiple unsupported clients (WhatsApp, Bluetooth etc)

* Changes made to let the user choose from the available email related clients only.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 25, 2018

Codecov Report

Merging #1204 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1204      +/-   ##
=========================================
- Coverage    3.82%   3.82%   -0.01%     
=========================================
  Files         125     125              
  Lines        5810    5811       +1     
  Branches      568     568              
=========================================
  Hits          222     222              
- Misses       5573    5574       +1     
  Partials       15      15
Impacted Files Coverage Δ
...free/nrw/commons/theme/NavigationBaseActivity.java 22.72% <0%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215c97e...81064de. Read the comment docs.

codecov-io commented Feb 25, 2018

Codecov Report

Merging #1204 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1204      +/-   ##
=========================================
- Coverage    3.82%   3.82%   -0.01%     
=========================================
  Files         125     125              
  Lines        5810    5811       +1     
  Branches      568     568              
=========================================
  Hits          222     222              
- Misses       5573    5574       +1     
  Partials       15      15
Impacted Files Coverage Δ
...free/nrw/commons/theme/NavigationBaseActivity.java 22.72% <0%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215c97e...81064de. Read the comment docs.

@neslihanturan

This comment has been minimized.

Show comment
Hide comment
@neslihanturan

neslihanturan Feb 26, 2018

Collaborator

Seems all correct to me, but I don't merge anything without testing. So probably this will be merged soon:)

Collaborator

neslihanturan commented Feb 26, 2018

Seems all correct to me, but I don't merge anything without testing. So probably this will be merged soon:)

@maskaravivek

LGTM. Tested on a real device. Works as expected. Congrats for your first contribution @ayushin78! :)

@neslihanturan I am going ahead and merging it.

@maskaravivek maskaravivek merged commit c51f3f0 into commons-app:master Feb 26, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ayushin78

This comment has been minimized.

Show comment
Hide comment
@ayushin78

ayushin78 Feb 26, 2018

Contributor

Thank you 😄

Contributor

ayushin78 commented Feb 26, 2018

Thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment