Show only the email clients in Feedback Feature (#1203) #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of showing only the email clients, The Feedback feature was showing multiple unsupported clients (WhatsApp, Bluetooth etc) * Changes made to let the user choose from the available email related clients only.
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
=========================================
- Coverage 3.82% 3.82% -0.01%
=========================================
Files 125 125
Lines 5810 5811 +1
Branches 568 568
=========================================
Hits 222 222
- Misses 5573 5574 +1
Partials 15 15
Continue to review full report at Codecov.
|
|
Seems all correct to me, but I don't merge anything without testing. So probably this will be merged soon:) |
maskaravivek
approved these changes
Feb 26, 2018
There was a problem hiding this comment.
LGTM. Tested on a real device. Works as expected. Congrats for your first contribution @ayushin78! :)
@neslihanturan I am going ahead and merging it.
|
Thank you 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1203
Instead of showing only the email clients, The Feedback feature was showing multiple unsupported clients (WhatsApp, Bluetooth etc). Changes made to display only the email clients.
Screenshots showing what changed