Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nearby activity: Stop the refresh and hide the layout #1293

Closed

Conversation

RiccardoGrigoletto
Copy link

Description
The nearby activity refresh layout (swipe up on the nearby activity) doesn't been hided when the refresh is aborted (for example, when the location doesn't change)
Now, if the refresh doesn't take place than the circle will be hided and the refresh will stop.

@neslihanturan
Copy link
Collaborator

Thanks a lot @RiccardoGrigoletto but unfortunately we are planning to remove manual refresh of nearby at all (#1271). Actually it currently it is not a good idea to work on nearby classes since we are trying to change something from the base.
It would be great if you create and issue before working on something and note you are willing to working on, so that someone can prevent your effort on it when it is improper.

@RiccardoGrigoletto
Copy link
Author

RiccardoGrigoletto commented Mar 12, 2018

@neslihanturan thank you for the advices.

@codecov-io
Copy link

Codecov Report

Merging #1293 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1293      +/-   ##
=========================================
- Coverage    3.77%   3.77%   -0.01%     
=========================================
  Files         125     125              
  Lines        5881    5886       +5     
  Branches      579     579              
=========================================
  Hits          222     222              
- Misses       5644    5649       +5     
  Partials       15      15
Impacted Files Coverage Δ
...ava/fr/free/nrw/commons/nearby/NearbyActivity.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2516445...0b03bf3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants