Fixes: Picture zoomed too much (#3312) #3315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing of image When a picture is clicked, the picture is zoomed to the point that parts of the picture are not visible. Change SimpleDraweeView property of actualImageScaleType from centerCrop to fitCenter
Codecov Report
@@ Coverage Diff @@
## master #3315 +/- ##
======================================
Coverage 7.5% 7.5%
======================================
Files 255 255
Lines 11206 11206
Branches 895 895
======================================
Hits 841 841
Misses 10303 10303
Partials 62 62Continue to review full report at Codecov.
|
nicolas-raoul
approved these changes
Jan 2, 2020
| @@ -5,7 +5,7 @@ | |||
| android:orientation="vertical" | |||
| android:layout_width="match_parent" | |||
| android:layout_height="match_parent" | |||
| android:background="?attr/mainBackground" | |||
| android:background="@color/black" | |||
There was a problem hiding this comment.
Why have we changed this, is this done, supporting the themes?
There was a problem hiding this comment.
I also don't understand why this change is made.
|
Fixed in #3422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #{3312} {images zoomed to much}
fragment_media_details.xml: changed property of SimpleDraweeView actualImageScaleType from centerCrop to fitCenter and changed background to black
Screenshots showing what changed (optional - for UI changes)
