Fixes #4255 - Media details activity shows depictions in random languages, rather than in the user's locale #4275
Conversation
|
@Pratham2305 could you post a screenshot of the fixed media details view, please? Thanks! |
|
@misaochan Yes, Posted! |
| for (IdAndCaptions idAndCaption : idAndCaptions) { | ||
| depictionContainer.addView(buildDepictLabel( | ||
| idAndCaption.getCaptions().values().iterator().next(), | ||
| //Check if the Depiction Caption is available in user's locale if not then check for english, else show any available. |
There was a problem hiding this comment.
I personally love ternary operations but using 2 levels of ternary makes it hard to read like a very long sentence. I am good to merge this PR after you turned them to use if braces. :)
Codecov Report
@@ Coverage Diff @@
## master #4275 +/- ##
============================================
- Coverage 10.40% 10.37% -0.04%
Complexity 474 474
============================================
Files 343 343
Lines 13069 13113 +44
Branches 1052 1060 +8
============================================
Hits 1360 1360
- Misses 11641 11684 +43
- Partials 68 69 +1
Continue to review full report at Codecov.
|
|
Wonderful, thank you @Pratham2305 ! Merging since @neslihanturan 's review has been addressed. :) |
Description (required)
Fixes #4255
What changes did you make and why?
Since App fetches a list of a depiction in different languages but I have noticed that depiction is only shown in the first language given in list, which is causing this issue. I have added the conditions Now it will first check if the depiction caption is available in the user's locale and if not then it will also check for English as it is the default language, else show in any available language.
Tests performed (required)
Tested prodDebug on Pixel 3 with API level 29.
(image selected from the feature tab with depictions)
https://commons.m.wikimedia.org/wiki/File%3AD%C3%BClmen%2C_Merfeld%2C_Feldweg_am_M%C3%BChlenbach_--_2021_--_4278-80.jpg
default language: English
Latest Master 3.0.0-debug
Updated