Fixed #5181 Misleading warning title for duplicate file name #5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/res/values/strings.xml
Outdated
| @@ -192,6 +192,7 @@ | |||
| <string name="location_permission_title">Requesting Location Permission</string> | |||
| <string name="ok">OK</string> | |||
| <string name="warning">Warning</string> | |||
| <string name="duplicate_file_name">Duplicate File Name found</string> | |||
| <string name="duplicate_image_found">Duplicate Image Found</string> | |||
There was a problem hiding this comment.
Is this duplicate_image_found still used somewhere?
There was a problem hiding this comment.
Seems like we can delete it
|
@nicolas-raoul I guess this pr is good to go? |
jocoand
approved these changes
Apr 2, 2023
nicolas-raoul
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5181
What changes did you make and why?
Added a new string resource to display in the alertdialog
Tests performed (required)
Tested locally on my device POCO X2, API Level 30
Screenshots (for UI changes only)