Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants file for map styles used across various fragments #5200

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

RitikaPahwa4444
Copy link
Collaborator

Description (required)

As discussed here, map styles have many usages in the app.

What changes did you make and why?

Added constants for all the map styles used in the app.

Tests performed (required)

Tested prodDebug on Redmi 5A with API level 27.

@RitikaPahwa4444
Copy link
Collaborator Author

The continuous integration is failing in the latest master too.

@RitikaPahwa4444
Copy link
Collaborator Author

@nicolas-raoul, I tried checking the differences on GitHub to see if any occurrence of Style.DARK:Style.OUTDOORS got overwritten during the rebase but the current version seems to cover all of them. Is there any occurrence you know might have got overwritten and GitHub is not showing it in the differences of that PR?

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, code is perfect, thanks a lot!

@nicolas-raoul nicolas-raoul merged commit cf35307 into commons-app:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants