5338 bug fix #5340
Merged
5338 bug fix #5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-raoul
requested changes
Oct 16, 2023
There was a problem hiding this comment.
I am able to reproduce the crash in main, and I confirm that this pull request fixes it.
Upload still works fine: https://commons.m.wikimedia.org/wiki/File%3AMarch_2007%2C_Old_house_in_Valleta.jpg
I just added two minor comments, would you mind editing?
Thanks a lot! :-)
nicolas-raoul
requested changes
Oct 16, 2023
| * Represents the default index for the language list. By default, this index corresponds to the | ||
| * English language. This serves as a fallback when the user's system language is not present in | ||
| * the language_list.xml. Though this default can be changed by the user, it does not affect other | ||
| * functionalities of the application. Fix bug issue 5338 |
There was a problem hiding this comment.
tiny change: Would you mind changing "Fix" to "Fixes" ?
There was a problem hiding this comment.
Hi, I fix that, can you make approval for it? Thanks!
|
Thanks a lot @1162706031 for fixing the bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5338 (you should insert the actual issue number if one exists)
What changes did you make and why?
Fixed a potential ArrayIndexOutOfBoundsException in LanguagesAdapter. The bug was due to the method getIndexOfUserDefaultLocale possibly returning -1 when the user's default locale wasn't found in the language. codes list. The returned value is now properly checked and, if -1, defaults to DEFAULT_INDEX which is set to 0.
Tests performed (required)
Tested ProdDebug on Pixel 3 with API level 30. (replace with actual device and API details)
After multiple rounds of testing, in the case of Chinese and other languages, the program will not directly crash during the process of selecting and uploading images.
Before, the app would crash instantly before reaching this page.
Screenshots (for UI changes only)
N/A (since this is a bug fix and doesn't involve any UI changes)
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.
Remember, it's important to actually test the changes on a real device or emulator before submitting a pull request to ensure that the bug is genuinely fixed and no new issues are introduced.