Add background color option for media detail page #5394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! |
nicolas-raoul
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #102
What changes did you make and why?
I add two menu items for transparent image only. It gives the user the possibility to change the background color to either black or white. I think you should do this instead of toggling the background color, because the background color is based on the user theme (dark or light mode). My solution works even if user change theme. The data is then saved into
SharedPreferences, (with the key specified by the media pageId).Tests performed (required)
I add two tests on the
MediaDetailPagerFragmentto verify if menu items are displayed only on transparent image.I add two tests on
MediaDetailFragmentto verify that we set the correct background color, only if it's not currently used.Tested BetaDebug on realme 10 with API level 33 - Android 13.
Screenshots (for UI changes only)
Screen.Recording.2023-11-23.at.21.18.49.mov