Removed butterknife from contributions list fragment

[psh]

This PR removes Butterknife from the ContributionsListFragment.

A large barrier to removing Butterknife from other places in the code is the plethora of mock UI elements that rely on Butterknife bound member variables. The PR introduces Google's FragmentScenario - designed for unit testing Fragments - along with a slight bump to some library versions.

FragmentScenario gives you complete control of the Fragment lifecycle and coupled with Robolectric allows you to safely run through the onCreateView() method to create real components removing the need for all the mock objects. As you can see from the PR, this greatly simplifies the test!

The pattern for other tests will be fairly similar to -

private lateinit var scenario: FragmentScenario<ContributionsListFragment>
private lateinit var fragment: ContributionsListFragment

and in the setup method

scenario = launchFragmentInContainer(
    initialState = Lifecycle.State.RESUMED,
    themeResId = R.style.LightAppTheme
) {
    ContributionsListFragment().apply {
        // ... setup mock objects on the target class, if needed
    }.also {
        fragment = it
    }
}

if you dont want to keep a fragment reference, then use FragmentScenario -

scenario.onFragment {
    // "it" is the fragment we're testing
    it.adapter = adapter
}

[nicolas-raoul]

Apparently for this branch unit tests fail with this:

Duplicate class kotlin.internal.jdk7.JDK7PlatformImplementations$ReflectSdkVersion found in modules jetified-kotlin-stdlib-1.8.20 (org.jetbrains.kotlin:kotlin-stdlib:1.8.20) and jetified-kotlin-stdlib-jdk7-1.7.20 (org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.7.20)

Any idea what might be the issue?

[psh]

Been a busy couple of weeks - I will look into this. No idea about why yet though.

[psh]

StackOverflow had an answer - looks like things build now.

[nicolas-raoul]

Tested, everything working fine.
Thanks! :-)