Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue of dark icons not visible in bottom NavBar and Achievement Fragments, in dark mode #5410

Merged

Conversation

ShashwatKedia
Copy link
Contributor

Description (required)

This PR resolves the issue of visibility of black/dark blue coloured icons in the bottom navigation bar and in the achievements fragment.

Fixes #5194

What changes did you make and why?

  1. For the info icon in the Achievements fragment, I changed the colour-tint of icons to primaryLightColour
  2. For the BottomNavbar icons, I changed the 'color_state_nav_tab_dark' to primaryLightColour
  3. Additionally, I noticed that the floating button's plus sign was not aligned with the UI guidelines for dark mode, so I added a tint colour to it

Tests performed (required)

Tested betaDebug on OnePlus Nord CE 2 Lite with API level 31.

Screenshots (for UI changes only)

Issue ss1

Issue ss 2

@nicolas-raoul
Copy link
Member

Looks great! Would you mind posting screenshots showing light mode too?

@ShashwatKedia
Copy link
Contributor Author

Sure! There you go!

issue light mode 2

issue light mode 1

@ShashwatKedia
Copy link
Contributor Author

@nicolas-raoul Sorry to disturb you, but if everything is okay, kindly merge the PR :)

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great now, thanks and sorry for the delay! :-)

@nicolas-raoul nicolas-raoul merged commit b3a4e87 into commons-app:main Jan 15, 2024
1 check passed
@ShashwatKedia
Copy link
Contributor Author

No issues, thanks for the merge!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some icons are barely visible in dark mode
2 participants