Fixed bitmap too large issue #5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the unit tests are failing due to some download issues |
|
In order to fix the unit tests, would you mind rebasing (or pulling) from main? Thanks :-) |
Done |
nicolas-raoul
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
I just tested using https://mnalis.com/tmp/IMG_20231116_161908.jpg :
- On the main branch I get a crash
- On this branch I get the finne Edit UI, ad am able to rotate the picture then upload it: https://commons.wikimedia.org/wiki/File:Building_and_cars_in_Croatia.jpg (and the uploaded picture has the same number of pixels as the original, in other words it is not the scaled-down version that gets uploaded).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5387
Fixed the error by scaling down the images if it is too large to handle