Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review Fix #5435

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

shashankiitbhu
Copy link
Contributor

@shashankiitbhu shashankiitbhu commented Jan 14, 2024

Description (required)

Fixes #5429

What changes did you make and why?
Added Logic to skip the Media in Peer Review if the user for the current media is same as the current user reviewing it.

Tests performed (required)

Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.

Screenshots (for UI changes only)

Need help? See https://support.google.com/android/answer/9075928


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am testing this branch. Unfortunately I still get pictures that I uploaded today:
Screenshot_20240115-150315.png

@shashankiitbhu
Copy link
Contributor Author

Sorry for that, I fixed it Please Review it

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work now, thanks! :-)

@nicolas-raoul nicolas-raoul merged commit 54c7187 into commons-app:main Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peer review: Do not make me review my own uploads
3 participants