Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Nearby Pins More Visible #5440

Merged
merged 11 commits into from
Jan 15, 2024
Merged

Made Nearby Pins More Visible #5440

merged 11 commits into from
Jan 15, 2024

Conversation

rohit9625
Copy link
Contributor

Description (required)
Fixes #5438

What changes did you make and why?
I updated the ic_custom_map_marker.xml to change the color from #006699 to #2CB7A9. After this, the marker becomes more visible in both dark and light themes.

Tests performed (required)

Tested betaDebug on Samsung A14 with API level 34.

Screenshots (for UI changes only)
Changes in light mode
![WhatsApp Image 2024-01-15 at 14 42 11_9fa183fa](https://github.com/commons-app/apps-android-
commons/assets/101377978/f0b0feb1-98d2-4b5a-9426-185fb78d5e23)

Changes in dark mode
WhatsApp Image 2024-01-15 at 14 42 11_d628f5c6

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it is more visible now. :-)

@nicolas-raoul nicolas-raoul merged commit dd605fb into commons-app:main Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nearby pins hard to see in dark mode
2 participants