Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5439 by capitalizing first letter of voice input #5450

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

kanahia1
Copy link
Contributor

Description (required)

Fixes #5439

What changes did you make and why?

Tests performed (required)

Tested betaDebug on Samsung S21 FE with API level 33.

Screenshots (for UI changes only)

WhatsApp.Video.2024-01-17.at.16.28.14_44836acb.mp4

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for English.
Also tried for Japanese, no side effect.

@nicolas-raoul nicolas-raoul merged commit b7323d0 into commons-app:main Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voice input should capitalize first letter
2 participants