Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UploadMediaDetailInputFilter: added a pattern to identify colon. #5451

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

rohit9625
Copy link
Contributor

Description (required)
Added hex code of colon for MediaDetailInputFilter and updated test for it.

Fixes #5416

What changes did you make and why?
In the file UploadMediaDetailInputFilter.java, I added a pattern that identifies colon that needs to be filtered from the caption.
Also updated test - testFilterControlCharacters() in file MediaDetailInputFilterTest.kt.

Tests performed (required)
1 Test - testFilterControlCharacters() passed.
Also, manually tested it on my device.

Tested betaDebug on Samsung A14 with API level 34.

Screenshots (for UI changes only)
No UI changes.

Added hex code of colon for MediaDetailInputFilter and updated test for it.
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolas-raoul nicolas-raoul merged commit 11e7b1c into commons-app:main Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared 15 pictures from gallery, but only 1 uploaded
2 participants