Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move thanks API into main commons codebase #5463

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

psh
Copy link
Collaborator

@psh psh commented Jan 22, 2024

Very quick refactor -

  • Moved the "thanks" API call (last step of a review) into the main code-base, out of the data client
  • Converted the API interface and the response class to kotlin
  • Setup injection to pass the ThanksInterface into the ThanksClient instead of the large Service interface from the data-client

In the process, I updated the unit test (swapping from Service to ThanksInterface) but otherwise keeping the functionality intact. Tested in the running app and all seems to be fine.

This relates to the discussion in #5165

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested, it works great, thanks a lot! :-)

@nicolas-raoul nicolas-raoul merged commit ef47b70 into commons-app:main Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants